Search missing on some pages

This topic contains 21 replies, has 2 voices, and was last updated by  Vinod Dalvi 2 weeks, 2 days ago.

  • Author
    Posts
  • #2096
    tanyathib
    Participant
    • Topics: 1
    • Replies: 12
    • Total: 13

    Hi there, I’m finding that the search isn’t showing up on all pages… specifically it’s missing from some of the custom_post types. They are checked off in settings (screenshot attached). Also, I’ve added it to the primary navigation menu, which is a dropdown in this theme. It does show up and technically works, but to the user it doesn’t look like it works. I’ve attached a short recording showing these issues. Unfortunately the site is a locked down membership for a client of mine, so I can’t give you access into it, but the URL is: http://aptsonictent.wp60.com/ Thank you for your help, let me know if you require anything further from me.

    Attachments:
    You must be logged in to view attached files.
  • #2099
    Vinod Dalvi
    Keymaster
    • Topics: 0
    • Replies: 134
    • Total: 134

    Hi Tanyathib,

    I hope you are well today and thank you for your question.

    As i can’t access your site so could you please share me the screenshots of the issue so that i can better understand the issue and help you?

    Best regards,
    Vinod Dalvi

  • #2100
    tanyathib
    Participant
    • Topics: 1
    • Replies: 12
    • Total: 13

    Hi Vinod 🙂 The files are attached to the original message, but did you get my email reply with them as well? Tanya

  • #2101
    Vinod Dalvi
    Keymaster
    • Topics: 0
    • Replies: 134
    • Total: 134

    In your initial post you have only attached screenshot of plugin settings but not the screenshot of issue that you are facing.

    What is the title of email that you have sent? Please be a bit more specific as i get a lot emails every day.

  • #2102
    tanyathib
    Participant
    • Topics: 1
    • Replies: 12
    • Total: 13

    The email was just a reply to your last one… but I’ve replied again and changed the subject line to:

    Recording of issue Re: [Free WP TP] Search missing on some pages

    And attached the recording again.

    The recording is showing as linked on my original post when I look at it. It’s called: 2017-08-26_0941.mp4

    I’ve attached it to this reply as well. It’s a small file, only 100kb, so it shouldn’t be an issue.

    Tanya

    Attachments:
    You must be logged in to view attached files.
  • #2105
    Vinod Dalvi
    Keymaster
    • Topics: 0
    • Replies: 134
    • Total: 134

    I didn’t get any email. Please do not just reply to the forum email, instead please create and send me separate email.

    Also your shared video file is not getting downloaded for me.

  • #2106
    tanyathib
    Participant
    • Topics: 1
    • Replies: 12
    • Total: 13

    Hi Vinod, well I certainly had challenges with that file! lol here’s a youtube link instead: https://youtu.be/tZ3SsP5I5Ko

  • #2107
    Vinod Dalvi
    Keymaster
    • Topics: 0
    • Replies: 134
    • Total: 134

    Thank you for sharing the video. I understood your issue now but it is very specific to your site so i need to access it to troubleshoot the issue.

    Would you mind if i log in to your site and do some troubleshooting? If this is ok then could you please share me your site log in details privately by checking the option “Set as private reply” when replying to this topic?

  • #2109
    tanyathib
    Participant
    • Topics: 1
    • Replies: 12
    • Total: 13
    This reply has been marked as private.
  • #2110
    tanyathib
    Participant
    • Topics: 1
    • Replies: 12
    • Total: 13

    Hi again Vinod, in order to fix the right align mentioned in my private message I had to edit the php file to this:

    $items .= ‘<li style=”float: right;” class=”‘ . esc_attr( $search_class ) . ‘”>’;

    But of course on updates that will be lost… so are you able to tell from this why the custom CSS wouldn’t work to right align?

  • #2111
    tanyathib
    Participant
    • Topics: 1
    • Replies: 12
    • Total: 13

    AH! Got the right align 🙂 It needed !important adding to the CSS.

    Unfortunately, from the private message I sent with login details… it’s really item #3 that is the primary issue now. Hopefully he’ll grant permission for you to have access to see if we can fix that part.

    (My client said to take the search out of the top right profile menu, so item #2 doesn’t matter to me any more, but you’re welcome to test in my site if you want to figure out why it doesn’t work.)

    • #2112
      tanyathib
      Participant
      • Topics: 1
      • Replies: 12
      • Total: 13

      Bah, I meant item #1 doesn’t matter and item #2 has been fixed. 🙂

  • #2116
    Vinod Dalvi
    Keymaster
    • Topics: 0
    • Replies: 134
    • Total: 134

    Ok then let’s wait for your client to provide us access to troubleshoot it.

  • #2135
    tanyathib
    Participant
    • Topics: 1
    • Replies: 12
    • Total: 13
    This reply has been marked as private.
  • #2141
    Vinod Dalvi
    Keymaster
    • Topics: 0
    • Replies: 134
    • Total: 134

    It was your site specific issue so i resolved the issue on your main site http://aptsonictent.wp60.com/ by editing the plugin code in the file add-search-to-menu/public/class-astm-public.php as following.

    Before:

    
    		/**
    		 * Displays search form in the navigation bar in the front end of site.
    		 */
    		function search_menu_item( $items, $args ) {
    			if ( isset( $this->opt['add_search_to_menu_locations'] ) && isset( $this->opt['add_search_to_menu_locations'][ $args->theme_location ] ) ) {
    

    After:

    
    		/**
    		 * Displays search form in the navigation bar in the front end of site.
    		 */
    		function search_menu_item( $items, $args ) {
    
    			if ( isset( $this->opt['add_search_to_menu_locations'] ) && ( isset( $this->opt['add_search_to_menu_locations'][ $args->theme_location ] ) || empty( $args->theme_location ) ) ) {
    
  • #2145
    tanyathib
    Participant
    • Topics: 1
    • Replies: 12
    • Total: 13

    Awesome Vinod! Thank you so much 🙂

  • #2146
    tanyathib
    Participant
    • Topics: 1
    • Replies: 12
    • Total: 13

    Quick question – will this need to be fixed again each time the plugin is updated now? I’ve applied the same change to the other site and it worked like a dream and I’ve saved the before and after in case I do need it in future – just thought I’d ask. Thanks.

  • #2147
    Vinod Dalvi
    Keymaster
    • Topics: 0
    • Replies: 134
    • Total: 134

    Yes you have to make this change every time after updating the plugin as the plugin update overwrites plugin files.

  • #2148
    tanyathib
    Participant
    • Topics: 1
    • Replies: 12
    • Total: 13

    Yes, ok, that’s what I thought, just wanted to double check. Thank you.

  • #2149
    Vinod Dalvi
    Keymaster
    • Topics: 0
    • Replies: 134
    • Total: 134

    You are most welcome, I’m glad I was able to help you in this matter. There is no obligation but by your kind words I wonder if I could trouble you to leave a review based on this experience here:

    https://wordpress.org/support/plugin/add-search-to-menu/reviews/?filter=5

    We’d really appreciate that. 🙂

    And if i can be of any further assistance please don’t hesitate to ask.

  • #2150
    tanyathib
    Participant
    • Topics: 1
    • Replies: 12
    • Total: 13

    Happy to do so – and done! 🙂

  • #2151
    Vinod Dalvi
    Keymaster
    • Topics: 0
    • Replies: 134
    • Total: 134

    Thank you for your detailed feedback. I really appreciate it 🙂

You must be logged in to reply to this topic.